Colours in emails in dark mode

Post a reply

Confirmation code
Enter the code exactly as it appears. All letters are case insensitive.
Smilies
:points: :-D :eyeroll: :neutral: :nmr: :razz: :raging: :-) ;) :( :sick: :o :? 8-) :x :shock: :lol: :cry: :evil: :?: :smirk: :!:
View more smilies

BBCode is ON
[img] is ON
[flash] is OFF
[url] is OFF
Smilies are ON

Topic review
   

If you wish to attach one or more files enter the details below.

Expand view Topic review: Colours in emails in dark mode

Re: Colours in emails in dark mode

by A_Tin_Can » Fri Sep 25, 2020 8:08 am

I mean, I'm playing diplomacy again, so things have obviously gotten pretty bad.

Re: Colours in emails in dark mode

by Claesar » Fri Sep 25, 2020 6:31 am

To lose something you need to have it first :?

Re: Colours in emails in dark mode

by Peregrine Falcon » Thu Sep 24, 2020 11:56 pm

I'm confused. Is Tim talking to himself? Has he finally lost it?

Re: Colours in emails in dark mode

by Claesar » Thu Sep 24, 2020 9:45 am

That's a very good observation; I am not logged in automatically on Edge or Mozilla.

Re: Colours in emails in dark mode

by A_Tin_Can » Thu Sep 24, 2020 9:14 am

Unfortunately, I saw the issue in Chrome.

Note that you're a moderator, and go through a different code path to us plebs. I suspect you were not logged in in the browsers where you saw the issue.

The offending code is here:

https://github.com/kestasjk/webDiplomac ... e.php#L825

Which browser you're using shouldn't make a difference.

Re: Colours in emails in dark mode

by Claesar » Thu Sep 24, 2020 6:20 am

I see the same on Edge and Mozilla, but not Chrome. Chrome works beautifully. I recommend it. It's my fav.

Re: Colours in emails in dark mode

by A_Tin_Can » Thu Sep 24, 2020 6:13 am

Oh! You're welcome. It's nice to be appreciated.

Re: Colours in emails in dark mode

by A_Tin_Can » Thu Sep 24, 2020 6:12 am

No, I don't have the time. I do appreciate the contributions from those who do, like yourself.

Re: Colours in emails in dark mode

by A_Tin_Can » Thu Sep 24, 2020 6:11 am

Thanks for the report! Would you consider submitting a PR?

Colours in emails in dark mode

by A_Tin_Can » Thu Sep 24, 2020 6:11 am

When your webdip display mode is set to dark and you look at a player profile with a public email address (eg http://webdiplomacy.net/profile.php?userID=36106), then the email address is displayed in light mode colours,

See here https://github.com/kestasjk/webDiplomacy/issues/703

Also, the bug report link in the footer goes to github, but maybe this is the right place to report issues? IDK.

Top