webDiplomacy.net new server

Site announcements from the moderator team go here.
Message
Author
desdemona22
Posts: 9
Joined: Tue Feb 04, 2020 10:05 pm
Karma: 15

Re: webDiplomacy.net new server

#41 Post by desdemona22 » Tue Jul 06, 2021 7:23 am

The process for my game just got rebooted multiple times over the span of 5 minutes or so resulting in all players going into civil disorder and getting booted (then turning into a draw which I wasn't part of :cry: )

https://webdiplomacy.net/board.php?gameID=354868

Not sure if this can be reversed and you can reinstate players into the game or not...
1

Claesar
Posts: 1932
Joined: Tue Oct 03, 2017 10:34 am
Karma: 1450

Re: webDiplomacy.net new server

#42 Post by Claesar » Tue Jul 06, 2021 8:09 am

Please email the mods at webdipmod@gmail.com
1

teccles
Posts: 213
Joined: Mon Mar 25, 2019 8:10 pm
Karma: 242

Re: webDiplomacy.net new server

#43 Post by teccles » Tue Jul 06, 2021 8:19 am

Much less bad, but I also had a game that double-processed an hour ago and gave me a missed turn: https://webdiplomacy.net/board.php?gameID=366305.
1

captainmeme
Posts: 260
Joined: Fri Sep 29, 2017 3:06 pm
Location: Manchester, UK
Karma: 544

Re: webDiplomacy.net new server

#44 Post by captainmeme » Tue Jul 06, 2021 8:34 am

teccles wrote:
Tue Jul 06, 2021 8:19 am
Much less bad, but I also had a game that double-processed an hour ago and gave me a missed turn: https://webdiplomacy.net/board.php?gameID=366305.
This one was because I messed around with it a bit to get it to start, sorry!
2

kestasjk
Co-Owner
Co-Owner
Posts: 104
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Karma: 314
Contact:

Re: webDiplomacy.net new server

#45 Post by kestasjk » Tue Jul 06, 2021 1:57 pm

desdemona22 wrote:
Tue Jul 06, 2021 7:23 am
The process for my game just got rebooted multiple times over the span of 5 minutes or so resulting in all players going into civil disorder and getting booted (then turning into a draw which I wasn't part of :cry: )

https://webdiplomacy.net/board.php?gameID=354868

Not sure if this can be reversed and you can reinstate players into the game or not...
Damn it.. apologies there, I didn't take into account how votes and game processing interact and it moved the game ahead instead of processing the draw vote.
Looks like some people were pretty quick to sneak in and take advantage of that! Let me fix that up..
2

Nescio
Posts: 23
Joined: Sat Mar 02, 2019 9:52 pm
Karma: 14

Re: webDiplomacy.net new server

#46 Post by Nescio » Tue Jul 06, 2021 2:14 pm

Changes are being made to the game processor to prevent game locking issues. You may notice live games not processing immediately; processing should complete in less than a minute.
About half an hour ago, I experienced a problem similar to @desdemona22's: I went into civil disorder in a bot game: https://webdiplomacy.net/board.php?gameID=366377
However, if you check the maps or orders, you'll see I actually didn't miss any. It all went very quickly, here are the in-game message:
03:35 PM: GameMaster wrote:Game was extended due to at least 1 member failing to enter orders and having an excused missed turn available. This has un-readied all orders.
03:37 PM: GameMaster wrote:Game was extended due to at least 1 member failing to enter orders and having an excused missed turn available. This has un-readied all orders.
03:38 PM: GameMaster wrote:Game was extended due to at least 1 member failing to enter orders and having an excused missed turn available. This has un-readied all orders.
03:39 PM: GameMaster wrote:Game was extended due to at least 1 member failing to enter orders and having an excused missed turn available. This has un-readied all orders.
03:40 PM: GameMaster wrote:Game was extended due to at least 1 member failing to enter orders and having an excused missed turn available. This has un-readied all orders.
Please note the time stamps.

And these were the notices outside the game:
Notices wrote: Against bots-6
03:40 PM Recent message
The game ended and your empire survived, but it was in civil disorder. Better luck next time!

Against bots-6
03:40 PM Recent message
You have missed a deadline and have no excuses left. You missed 1 deadline without an excuse during this year. 3 more misses will impose a temporary ban on you.

Against bots-6
03:40 PM Recent message
Your empire has gone inactive, and fallen into civil disorder. It can now be taken over by anyone, unless you take it back!

Against bots-6
03:39 PM Recent message
Game phase extended due to missing orders by at least one country.

Against bots-6
03:39 PM Recent message
You have missed a deadline and lost an excuse (0 left). Be more reliable!

Against bots-6
03:39 PM Recent message
Game progressed to Builds, Autumn, 1906

Against bots-6
03:38 PM Recent message
Game progressed to Retreats, Autumn, 1906

Against bots-6
03:38 PM Recent message
Game phase extended due to missing orders by at least one country.

Against bots-6
03:38 PM Recent message
You have missed a deadline and lost an excuse (1 left). Be more reliable!

Against bots-6
03:37 PM Recent message
Game progressed to Diplomacy, Autumn, 1906

Against bots-6
03:37 PM Recent message
Game phase extended due to missing orders by at least one country.

Against bots-6
03:37 PM Recent message
You have missed a deadline and lost an excuse (2 left). Be more reliable!

Against bots-6
03:36 PM Recent message
Game progressed to Diplomacy, Spring, 1906

Against bots-6
03:36 PM Recent message
Game progressed to Builds, Autumn, 1905

Against bots-6
03:35 PM Recent message
Game phase extended due to missing orders by at least one country.

Against bots-6
03:35 PM Recent message
You have missed a deadline and lost an excuse (3 left). Be more reliable!

Against bots-6
03:34 PM Recent message
Game progressed to Diplomacy, Autumn, 1905

Against bots-6
03:33 PM Recent message
Game progressed to Retreats, Spring, 1905

Against bots-6
03:32 PM Recent message
Game progressed to Diplomacy, Spring, 1905
Could you investigate?
2

kestasjk
Co-Owner
Co-Owner
Posts: 104
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Karma: 314
Contact:

Re: webDiplomacy.net new server

#47 Post by kestasjk » Tue Jul 06, 2021 2:40 pm

Hi Nescio,

Did you put in any votes or did you have any votes going before it started processing in a loop?

The issue should be resolved, but if this happened due to you placing a vote it would make sense, but if it happened spontaneously there might be something strange going on with the bot voting logic (and that would make sense of some other things)
2

desdemona22
Posts: 9
Joined: Tue Feb 04, 2020 10:05 pm
Karma: 15

Re: webDiplomacy.net new server

#48 Post by desdemona22 » Tue Jul 06, 2021 2:45 pm

kestasjk wrote:
Tue Jul 06, 2021 1:57 pm
desdemona22 wrote:
Tue Jul 06, 2021 7:23 am
The process for my game just got rebooted multiple times over the span of 5 minutes or so resulting in all players going into civil disorder and getting booted (then turning into a draw which I wasn't part of :cry: )

https://webdiplomacy.net/board.php?gameID=354868

Not sure if this can be reversed and you can reinstate players into the game or not...
Damn it.. apologies there, I didn't take into account how votes and game processing interact and it moved the game ahead instead of processing the draw vote.
Looks like some people were pretty quick to sneak in and take advantage of that! Let me fix that up..
That explains it, I had just thrown up my draw vote and the problem started. Thanks so much for fixing though!
1

Nescio
Posts: 23
Joined: Sat Mar 02, 2019 9:52 pm
Karma: 14

Re: webDiplomacy.net new server

#49 Post by Nescio » Tue Jul 06, 2021 4:02 pm

kestasjk wrote:
Tue Jul 06, 2021 2:40 pm
Hi Nescio,

Did you put in any votes or did you have any votes going before it started processing in a loop?

The issue should be resolved, but if this happened due to you placing a vote it would make sense, but if it happened spontaneously there might be something strange going on with the bot voting logic (and that would make sense of some other things)
Yes, I think I had voted for a draw, though I believe that was some time before the game unexpectedly ended.
Regardless, games shouldn't end because someone has voted.
By the way, the problem feels similar to one I reported some time ago (see here), though the outcome is different (civil disorder instead of draw).
1

yavuzovic
Posts: 2877
Joined: Tue Oct 03, 2017 2:42 pm
Location: Sakarya/Turkey
Karma: 563
Contact:

Re: webDiplomacy.net new server

#50 Post by yavuzovic » Tue Jul 06, 2021 5:04 pm

Same problem with Nescio, I'm temporarily blocked from joining games and lost some RR
1

goldfinger0303
Site Moderator
Site Moderator
Posts: 1486
Joined: Fri Sep 29, 2017 3:17 pm
Karma: 792

Re: webDiplomacy.net new server

#51 Post by goldfinger0303 » Tue Jul 06, 2021 5:24 pm

Hey guys for stuff like RR impacts just send an email to the mods and we'll take care of it. Let's try to keep this thread focused on any actual bugs themselves.
2

Tjappator
Posts: 21
Joined: Wed Mar 24, 2021 3:02 pm
Karma: 20

Re: webDiplomacy.net new server

#52 Post by Tjappator » Tue Jul 06, 2021 6:15 pm

I currently have a player match which is not recognizing that all the players have readied up. I am the only player that has retreats and I have readied up. So perhaps there is now an issue there?
3

MKECharlie
Gold Donator
Gold Donator
Posts: 5
Joined: Fri Jan 12, 2018 4:17 am
Location: Milwaukee, WI
Karma: 14
Contact:

Re: webDiplomacy.net new server

#53 Post by MKECharlie » Tue Jul 06, 2021 7:21 pm

Home page seems to have an error showing up.
Deprecated: Function get_magic_quotes_gpc() is deprecated in /var/www/webdiplomacy.net/public_html/header.php on line 95
1

jmo1121109
Developer
Developer
Posts: 1074
Joined: Fri Sep 29, 2017 4:20 pm
Karma: 2854
Contact:

Re: webDiplomacy.net new server

#54 Post by jmo1121109 » Tue Jul 06, 2021 9:34 pm

MKECharlie wrote:
Tue Jul 06, 2021 7:21 pm
Home page seems to have an error showing up.
Deprecated: Function get_magic_quotes_gpc() is deprecated in /var/www/webdiplomacy.net/public_html/header.php on line 95
Are you still seeing that? I can't reproduce it.
1

President Eden
Posts: 3027
Joined: Fri Oct 20, 2017 2:11 pm
Karma: 4936

Re: webDiplomacy.net new server

#55 Post by President Eden » Tue Jul 06, 2021 10:11 pm

I saw it earlier but it's gone now for me as well.
2

MKECharlie
Gold Donator
Gold Donator
Posts: 5
Joined: Fri Jan 12, 2018 4:17 am
Location: Milwaukee, WI
Karma: 14
Contact:

Re: webDiplomacy.net new server

#56 Post by MKECharlie » Wed Jul 07, 2021 1:21 am

President Eden wrote:
Tue Jul 06, 2021 10:11 pm
I saw it earlier but it's gone now for me as well.
Yeah, agreed. It's gone.
1

kestasjk
Co-Owner
Co-Owner
Posts: 104
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Karma: 314
Contact:

Re: webDiplomacy.net new server

#57 Post by kestasjk » Wed Jul 07, 2021 2:45 am

Yep that's fixed, I just turned up the error reporting to show warnings and previously that was under the threshold to report.

Looking promising.. no deadlocks, stable speeds and no issues for a few hours at least .. Image

Still more optimizations to go but I think we're making progress
4

Tjappator
Posts: 21
Joined: Wed Mar 24, 2021 3:02 pm
Karma: 20

Re: webDiplomacy.net new server

#58 Post by Tjappator » Wed Jul 07, 2021 7:36 am

It indeed appears to run smoothly now.

However games with all players ready are not processing before the time is up. They do process after the time expires.
My guess is that you disabled the path where readying up allows to process games?

kestasjk
Co-Owner
Co-Owner
Posts: 104
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Karma: 314
Contact:

Re: webDiplomacy.net new server

#59 Post by kestasjk » Wed Jul 07, 2021 11:43 am

Ah thanks I think I missed that. Okay, I think this should be straightforward.

Good news that it seems smoother. Are there any pages in particular or just in general?


Votes previously caused an immediate process in the board code. The api/board code is best to tally votes/orders but not a good place to do game processing, deadlocks are inevitable. So instead it'll set a flag that will queue it for gamemaster. At the moment I don't think the gamemaster recognizes vote situations, which I'll check and resolve asap.

On that topic the server has some new tech to help with performance, memcached a quick caching engine, since there was a lot of repetitive queries that the built-in cache wasn't using, and it's good for firing messages like that around as well without needing to start up a database connection which is costlier than I might have thought.


There will still be a small delay so it won't be as snappy until we improve the tech, but it should be fine (we'll see).
2

Yonni
Silver Donator
Silver Donator
Posts: 322
Joined: Thu Oct 19, 2017 6:55 pm
Karma: 252

Re: webDiplomacy.net new server

#60 Post by Yonni » Wed Jul 07, 2021 11:52 am

Seems to be running quite smoothly here. Thanks, as always, for all the hard work Kestas.
1

Post Reply

Who is online

Users browsing this forum: No registered users and 5 guests