Ghost Rating formula incorrectly listed on /ghostRatings.php

Members can make suggestions for improving the site and improving the forum as well as submit bug reports to be reviewed by our support team here.
Post Reply
Message
Author
echidna
Posts: 52
Joined: Thu Nov 24, 2022 11:40 pm
Karma: 44
Contact:

Ghost Rating formula incorrectly listed on /ghostRatings.php

#1 Post by echidna » Mon Jul 24, 2023 5:18 am

Hi, I looked at the details of GhostRatings, described on page https://webdiplomacy.net/ghostRatings.php
I believe the formula listed there:
ratingAdjustment = x * (expectedScore - actualScore)
is INCORRECT!
It should read:
ratingAdjustment = x * (actualScore - expectedScore)

I found the piece of code:
$grAdjustment[$userID] = (($grSum / $this->modvalue) * ($actualResult[$userID]-$expectedResult[$userID]));
this clearly shows actual... - expected...

Doug7878
Gold Donator
Gold Donator
Posts: 574
Joined: Wed Feb 07, 2018 11:05 am
Location: Massachusetts, USA
Karma: 136
Contact:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

#2 Post by Doug7878 » Mon Jul 24, 2023 10:31 am

The (inquisitive) force is strong with this one. Yes, its clearly stated in reverse.

Can you fix the info page? If not, I guess you would send it to kestas. ( ? )

gimix
Site Moderator
Site Moderator
Posts: 349
Joined: Tue Nov 13, 2018 8:56 am
Location: My Mountains, the highest in Europe
Karma: 343
Contact:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

#3 Post by gimix » Mon Jul 24, 2023 11:57 am

@Squigs, are you still around?

gimix
Site Moderator
Site Moderator
Posts: 349
Joined: Tue Nov 13, 2018 8:56 am
Location: My Mountains, the highest in Europe
Karma: 343
Contact:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

#4 Post by gimix » Mon Jul 24, 2023 12:03 pm

(newer members info):
Squigs44 has been a very active and important member of this site, and contributed some nice pieces of code, including the full Ghost Rating system.

We are happy that he reversed Actual and Expected in the explanation, not in the code :lol:

x3n
Posts: 37
Joined: Thu Jan 31, 2019 2:35 am
Location: Earth
Karma: 19
Contact:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

#5 Post by x3n » Mon Jul 24, 2023 5:50 pm

While I appreciate the work, if Ghost Rating still encourages people to drop out of a game before they lose, and never help out a stalled game by taking up a doomed position, then I think it must still be considered a "work in progress".

User avatar
JECE
Posts: 1517
Joined: Sun Dec 31, 2017 4:35 pm
Karma: 405
Contact:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

#6 Post by JECE » Mon Jul 24, 2023 7:21 pm

x3n wrote:
Mon Jul 24, 2023 5:50 pm
While I appreciate the work, if Ghost Rating still encourages people to . . . never help out a stalled game by taking up a doomed position, then I think it must still be considered a "work in progress".
Restore PPSC and restore the practice of betting on joining games in progress. Problem solved without touching the Ghost Rating code!
See my full Profile:
http://www.webdiplomacy.net/profile.php?userID=17421

Post Reply

Who is online

Users browsing this forum: No registered users and 229 guests