Page 1 of 1
Joined as a replacement, but info shows non-zero bet?
Posted: Fri Mar 10, 2023 10:46 pm
by echidna
I replaced the player of Turkey in game 542882, I think at zero cost, but the info shows for me, as Turkey, Bet: 5. Was I mistaken and it wasn't zero cost to join? Not a problem if that's the case, I'm just wondering if instead its a bug or a change in policy.
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sat Mar 11, 2023 2:22 am
by JECE
Hmm, that's interesting. No gamemaster message notifying about any replacement either:
https://webdiplomacy.net/board.php?game ... e=Messages
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sat Mar 11, 2023 6:08 am
by echidna
In the list of Notices I get on my home page, there is one for when I joined the game (pp-36) saying "You took over Turkey! Good luck"
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sun Mar 12, 2023 6:57 pm
by JECE
I would submit a bug report here if you think that something might not be right:
https://webdiplomacy.net/modforum.php
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sun Mar 12, 2023 10:09 pm
by echidna
JECE, thanks for your guidance, I have submitted to that modforum.
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Wed Mar 15, 2023 12:21 pm
by Rainfromabove
Have the same issue actually - also posted a mod report
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Fri Mar 31, 2023 2:10 pm
by kestasjk
Hmm.. Looking at the code it does look like there is a bet to take over a CD:
https://github.com/kestasjk/webDiplomac ... s.php#L513
Code: Select all
$bet = $CD->pointsValueInTakeover();
if ( $User->points < $bet )
throw new Exception(l_t("You do not have enough points to take over that countryID."));
Oh wait, that value is always 0:
Code: Select all
/**
* CD takeovers cost 0. This is a function because they weren't always free, and keeping the function means we can always change it later.
* @return int
*/
function pointsValueInTakeover()
{
return 0;
}
So that bet amount is the amount the membership is worth, but no points were subtracted from your account to join.
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Fri Mar 31, 2023 9:26 pm
by jamesa7171
kestasjk wrote: ↑Fri Mar 31, 2023 2:10 pm
So that bet amount is the amount the membership is worth
The bet amount normally says "Bet: 0" after someone takes over a CD.
(eta: I also encountered this in a game and reported it a while back)
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Fri Mar 31, 2023 11:44 pm
by kestasjk
Hmm.. I'll have a look into why that might have changed, but in the meantime don't worry when you take over a CD no points are deducted
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sat Apr 01, 2023 12:45 am
by sweetandcool
Oh did you change it? Just last week I contacted support to get my points back because the game took them when I took over an open position.
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sat Apr 01, 2023 2:11 am
by kestasjk
Yep it didn't deduct any points, that ticket is resolved. I even checked the points transaction logs to double check and no points were taken when you joined
Re: Joined as a replacement, but info shows non-zero bet?
Posted: Sat Apr 01, 2023 3:28 am
by sweetandcool
Interesting. It still displays that I bet 5, so I guess it's just a display bug.