Colours in emails in dark mode

Members can make suggestions for improving the site and improving the forum as well as submit bug reports to be reviewed by our support team here.
Post Reply
Message
Author
A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Colours in emails in dark mode

#1 Post by A_Tin_Can » Thu Sep 24, 2020 6:11 am

When your webdip display mode is set to dark and you look at a player profile with a public email address (eg http://webdiplomacy.net/profile.php?userID=36106), then the email address is displayed in light mode colours,

See here https://github.com/kestasjk/webDiplomacy/issues/703

Also, the bug report link in the footer goes to github, but maybe this is the right place to report issues? IDK.
2

A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Re: Colours in emails in dark mode

#2 Post by A_Tin_Can » Thu Sep 24, 2020 6:11 am

Thanks for the report! Would you consider submitting a PR?
2

A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Re: Colours in emails in dark mode

#3 Post by A_Tin_Can » Thu Sep 24, 2020 6:12 am

No, I don't have the time. I do appreciate the contributions from those who do, like yourself.
2

A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Re: Colours in emails in dark mode

#4 Post by A_Tin_Can » Thu Sep 24, 2020 6:13 am

Oh! You're welcome. It's nice to be appreciated.
2

Claesar
Posts: 1965
Joined: Tue Oct 03, 2017 10:34 am
Karma: 1490
Contact:

Re: Colours in emails in dark mode

#5 Post by Claesar » Thu Sep 24, 2020 6:20 am

I see the same on Edge and Mozilla, but not Chrome. Chrome works beautifully. I recommend it. It's my fav.
1

A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Re: Colours in emails in dark mode

#6 Post by A_Tin_Can » Thu Sep 24, 2020 9:14 am

Unfortunately, I saw the issue in Chrome.

Note that you're a moderator, and go through a different code path to us plebs. I suspect you were not logged in in the browsers where you saw the issue.

The offending code is here:

https://github.com/kestasjk/webDiplomac ... e.php#L825

Which browser you're using shouldn't make a difference.
1

Claesar
Posts: 1965
Joined: Tue Oct 03, 2017 10:34 am
Karma: 1490
Contact:

Re: Colours in emails in dark mode

#7 Post by Claesar » Thu Sep 24, 2020 9:45 am

That's a very good observation; I am not logged in automatically on Edge or Mozilla.
1

Peregrine Falcon
Site Contributor
Site Contributor
Posts: 245
Joined: Tue Mar 14, 2017 8:44 pm
Karma: 310
Contact:

Re: Colours in emails in dark mode

#8 Post by Peregrine Falcon » Thu Sep 24, 2020 11:56 pm

I'm confused. Is Tim talking to himself? Has he finally lost it?
3

Claesar
Posts: 1965
Joined: Tue Oct 03, 2017 10:34 am
Karma: 1490
Contact:

Re: Colours in emails in dark mode

#9 Post by Claesar » Fri Sep 25, 2020 6:31 am

To lose something you need to have it first :?
3

A_Tin_Can
Lifetime Site Contributor
Posts: 283
Joined: Fri Sep 29, 2017 9:18 pm
Karma: 451
Contact:

Re: Colours in emails in dark mode

#10 Post by A_Tin_Can » Fri Sep 25, 2020 8:08 am

I mean, I'm playing diplomacy again, so things have obviously gotten pretty bad.
6

Post Reply

Who is online

Users browsing this forum: No registered users and 63 guests