Joined as a replacement, but info shows non-zero bet?

Members can make suggestions for improving the site and improving the forum as well as submit bug reports to be reviewed by our support team here.
Post Reply
Message
Author
User avatar
echidna
Posts: 53
Joined: Thu Nov 24, 2022 11:40 pm
Contact:

Joined as a replacement, but info shows non-zero bet?

#1 Post by echidna » Fri Mar 10, 2023 10:46 pm

I replaced the player of Turkey in game 542882, I think at zero cost, but the info shows for me, as Turkey, Bet: 5. Was I mistaken and it wasn't zero cost to join? Not a problem if that's the case, I'm just wondering if instead its a bug or a change in policy.

User avatar
JECE
Posts: 1638
Joined: Sun Dec 31, 2017 4:35 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#2 Post by JECE » Sat Mar 11, 2023 2:22 am

Hmm, that's interesting. No gamemaster message notifying about any replacement either:
https://webdiplomacy.net/board.php?game ... e=Messages
See my full Profile:
http://www.webdiplomacy.net/profile.php?userID=17421

User avatar
echidna
Posts: 53
Joined: Thu Nov 24, 2022 11:40 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#3 Post by echidna » Sat Mar 11, 2023 6:08 am

In the list of Notices I get on my home page, there is one for when I joined the game (pp-36) saying "You took over Turkey! Good luck"

User avatar
JECE
Posts: 1638
Joined: Sun Dec 31, 2017 4:35 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#4 Post by JECE » Sun Mar 12, 2023 6:57 pm

I would submit a bug report here if you think that something might not be right:
https://webdiplomacy.net/modforum.php
See my full Profile:
http://www.webdiplomacy.net/profile.php?userID=17421

User avatar
echidna
Posts: 53
Joined: Thu Nov 24, 2022 11:40 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#5 Post by echidna » Sun Mar 12, 2023 10:09 pm

JECE, thanks for your guidance, I have submitted to that modforum.

Rainfromabove
Posts: 30
Joined: Tue Jul 09, 2019 9:15 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#6 Post by Rainfromabove » Wed Mar 15, 2023 12:21 pm

Have the same issue actually - also posted a mod report

User avatar
kestasjk
Developer
Developer
Posts: 532
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#7 Post by kestasjk » Fri Mar 31, 2023 2:10 pm

Hmm.. Looking at the code it does look like there is a bet to take over a CD:
https://github.com/kestasjk/webDiplomac ... s.php#L513

Code: Select all

			$bet = $CD->pointsValueInTakeover();
			if ( $User->points < $bet )
				throw new Exception(l_t("You do not have enough points to take over that countryID."));
Oh wait, that value is always 0:

Code: Select all

	/**
	 * CD takeovers cost 0. This is a function because they weren't always free, and keeping the function means we can always change it later.
	 * @return int
	 */
	function pointsValueInTakeover() 
	{
		return 0;
	}	
So that bet amount is the amount the membership is worth, but no points were subtracted from your account to join.

jamesa7171
Posts: 28
Joined: Sat Jun 02, 2018 4:50 am
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#8 Post by jamesa7171 » Fri Mar 31, 2023 9:26 pm

kestasjk wrote:
Fri Mar 31, 2023 2:10 pm
So that bet amount is the amount the membership is worth
The bet amount normally says "Bet: 0" after someone takes over a CD.

(eta: I also encountered this in a game and reported it a while back)

User avatar
kestasjk
Developer
Developer
Posts: 532
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#9 Post by kestasjk » Fri Mar 31, 2023 11:44 pm

Hmm.. I'll have a look into why that might have changed, but in the meantime don't worry when you take over a CD no points are deducted

sweetandcool
Posts: 4065
Joined: Wed Jan 04, 2023 8:21 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#10 Post by sweetandcool » Sat Apr 01, 2023 12:45 am

Oh did you change it? Just last week I contacted support to get my points back because the game took them when I took over an open position.

User avatar
kestasjk
Developer
Developer
Posts: 532
Joined: Tue Mar 14, 2017 8:13 pm
Location: Perth, Australia
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#11 Post by kestasjk » Sat Apr 01, 2023 2:11 am

Yep it didn't deduct any points, that ticket is resolved. I even checked the points transaction logs to double check and no points were taken when you joined

sweetandcool
Posts: 4065
Joined: Wed Jan 04, 2023 8:21 pm
Contact:

Re: Joined as a replacement, but info shows non-zero bet?

#12 Post by sweetandcool » Sat Apr 01, 2023 3:28 am

Interesting. It still displays that I bet 5, so I guess it's just a display bug.

Post Reply

Who is online

Users browsing this forum: No registered users