Site wide notices and game tabs

Post a reply

Confirmation code
Enter the code exactly as it appears. All letters are case insensitive.
Smilies
:points: :-D :eyeroll: :neutral: :nmr: :razz: :raging: :-) ;) :( :sick: :o :? 8-) :x :shock: :lol: :cry: :evil: :?: :smirk: :!:
View more smilies

BBCode is ON
[img] is ON
[flash] is OFF
[url] is OFF
Smilies are ON

Topic review
   

If you wish to attach one or more files enter the details below.

Expand view Topic review: Site wide notices and game tabs

Re: Site wide notices and game tabs

by Tom Bombadil » Tue Apr 24, 2018 4:37 pm

Looks good. Thanks kestas

Re: Site wide notices and game tabs

by bo_sox48 » Tue Apr 24, 2018 4:31 pm

Seems like things are working for the world variant too. The !! works as well. Thanks kestas.

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 4:28 pm

Great, got there in the end. Thanks folks

Re: Site wide notices and game tabs

by bo_sox48 » Tue Apr 24, 2018 4:02 pm

Everything looks right now to me. Saved orders are gray, pauses don't affect anything. The pause icon is up there with saved orders as well. I can't test the !! though; I don't have any games where I haven't entered orders.

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:51 pm

Refreshed myself of the logic and hopefully it'll give the right results now?

(Believe it or not this is actually easier than setting up a test game with a bunch of fake users on my dev server, thanks for the patience)

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:40 pm

I don't suppose you're seeing a red ! where you want to see a gray tick? I can't find a gray ! in the icons folder

Re: Site wide notices and game tabs

by Peregrine Falcon » Tue Apr 24, 2018 3:38 pm

For me, saved is showing up as !! . Ready is not showing up.

Re: Site wide notices and game tabs

by ghug » Tue Apr 24, 2018 3:37 pm

Positioning is better. I'm still not seeing any gray.

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:34 pm

Okay, hopefully the icons are a bit higher and you're seeing some gray !! now?

Re: Site wide notices and game tabs

by ghug » Tue Apr 24, 2018 3:26 pm

Still no gray checkmark here.

This is nitpicky, but those icons are also too low in the boxes, at least on Android Chrome.

Re: Site wide notices and game tabs

by Peregrine Falcon » Tue Apr 24, 2018 3:25 pm

Same with the ready checkmark

Edit: x-post. Ready still !!

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:25 pm

How is it now bo (it's awkward to test)

Re: Site wide notices and game tabs

by bo_sox48 » Tue Apr 24, 2018 3:15 pm

Hey kestas, it looks to me like saved orders (gray check) appear as !! even though orders have actually been put in.

Re: Site wide notices and game tabs

by jmo1121109 » Tue Apr 24, 2018 3:14 pm

Colors and icons look great now! Thanks!

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:14 pm

No worries. Okay the !! icons should now be showing correctly without messing up the page. I thought I was seeing the same thing on my dev machine, but something weird was happening where a template file went missing and I'm not sure why..

Game colors should now be coming through also.

So can people please continue to report issues because I'm not sure what's fixed and what's not.

Re: Site wide notices and game tabs

by jmo1121109 » Tue Apr 24, 2018 3:04 pm

Also thanks for fixing the nan on +1’s!

Re: Site wide notices and game tabs

by jmo1121109 » Tue Apr 24, 2018 3:03 pm

Okay they are on my home laptop so I’ll email those over within 8 hours.

Re: Site wide notices and game tabs

by kestasjk » Tue Apr 24, 2018 3:00 pm

Ah yes that'd be the Allan silver header template which I had to alter to add the event hook in. Apologies for that; if you can send me your change I'll merge it and commit

Re: Site wide notices and game tabs

by jmo1121109 » Tue Apr 24, 2018 2:51 pm

Also seeing a new issue where all my games country color is showing as France blue despite me not being France in those games

Re: Site wide notices and game tabs

by jmo1121109 » Tue Apr 24, 2018 2:49 pm

Hey kestas, a while back I had added in 2 new top menu links for the new forum. To let people get to the new forum settings page. Looks like that got wiped out, if you have it saved could you add that back in? If not I’ll get it back up tonight.

The changes are awesome, thanks for doing this!

Top