If you wish to attach one or more files enter the details below. You may also attach files by dragging and dropping them in the message box.
by wulfheart » Sun Mar 19, 2023 5:40 pm
by JECE » Sun Mar 19, 2023 12:27 pm
wulfheart wrote: ↑Sun Mar 19, 2023 10:57 am There are even plenty of free feature request trackers online available. Just noting.
by wulfheart » Sun Mar 19, 2023 10:59 am
kestasjk wrote: ↑Sat Mar 18, 2023 4:51 am wulfheart wrote: ↑Fri Mar 17, 2023 6:40 pm I habe thought about refactoring for a long time. Would you be open for a gradual refactoring and automated tests? Of course The dev environment is pretty nice these days, you can grab docker and VS code and be up and running even with MILA bots in no time, it'd be very neat to have a test suite (beyond the DATC tests, which cover the adjudicator pretty well)
wulfheart wrote: ↑Fri Mar 17, 2023 6:40 pm I habe thought about refactoring for a long time. Would you be open for a gradual refactoring and automated tests?
by wulfheart » Sun Mar 19, 2023 10:57 am
by Chaqa » Sat Mar 18, 2023 2:04 pm
by kestasjk » Sat Mar 18, 2023 4:51 am
by learnedSloth » Fri Mar 17, 2023 9:50 pm
kestasjk wrote: ↑Fri Mar 17, 2023 6:34 am The new GitHub ChatGPT Copilot feature is really neat, I just typed Code: Select all if( !is_null($Game->sandboxCreatedByUserID) And it actually generated this as a suggestion: Code: Select all if( !is_null($Game->sandboxCreatedByUserID) && $Game->sandboxCreatedByUserID != $User->id && !$User->type['Moderator'] ) { libHTML::notice('Access denied',l_t("You can't view this game, it is a sandbox game which you didn't create.")); } It guessed I wanted to filter out users that hadn't created the game, knew to add a check for moderator user type, knew to send the error through the translation error, very smart
Code: Select all
if( !is_null($Game->sandboxCreatedByUserID)
if( !is_null($Game->sandboxCreatedByUserID) && $Game->sandboxCreatedByUserID != $User->id && !$User->type['Moderator'] ) { libHTML::notice('Access denied',l_t("You can't view this game, it is a sandbox game which you didn't create.")); }
by wulfheart » Fri Mar 17, 2023 6:40 pm
by kestasjk » Fri Mar 17, 2023 6:34 am
Rainfromabove wrote: ↑Fri Mar 17, 2023 3:47 am Thank you Kestas, really appreciate the timely responses to feedback - think on the flipside of all the complaining, your interactions and acknowledgements I think that has been a major positive since you started being more involved and proactive again
sweetandcool wrote: ↑Fri Mar 17, 2023 3:36 am The white screen problem mostly happens in bot games/sandbox, but it has happened a couple of times in gunboat. The game will have a single red "!", similar to the double red "!!". The drop down will show an order that is empty and as long as you enter a valid order the point and click will start working again instead of being a white screen. I will try to remember to report it to you next time, instead of fixing it myself.
The sandbox is awful. Imagine being a new player, noticing the awesome sandbox feature, defaulting to point and click, and then having it behave in a buggy broken way. You've mentioned before that you haven't gotten the build phase to work. Well, even the other phases don't work. You'll enter a few orders and then the game will progress on its own. Or you'll be "assigned" a country with no units and the game doesn't let you progress. And for some reason sandbox "games" show up as joinable games. So the whole front page list of joinable games is an endless list of disappointing sandbox "games". Not only is that a horrible look for the homepage, but it leaks information, rendering analysis useless since anyone can view it.
Shouldn't these new features be beta tested before being released? Sandbox should not be available until it actually works in the UI you expect everybody to use. Lastly, I just realized you addressed some of these issues in a previous post. But I've already drafted this post, and it's good to point out these issues again anyways.
function usePointAndClickUI() { global $User; return $this->isClassicGame() && (defined('PLAYNOW') || !isset($User) || !$User->type['User'] || $User->isMapUIPointAndClick() ) && is_null($this->sandboxCreatedByUserID); // Sandbox games currently not supported for build mode in point and click UI }
by Rainfromabove » Fri Mar 17, 2023 3:47 am
by sweetandcool » Fri Mar 17, 2023 3:36 am
by kestasjk » Fri Mar 17, 2023 2:48 am
sweetandcool wrote: ↑Thu Mar 16, 2023 6:00 pm I've also taken note that a lot of changes made recently seem very half-baked, which is frustrating for users. I admire the enthusiasm of the dev to try pumping out changes people want, but it is frustrating dealing with broken features. The point and click map should still be in beta since it still is not uncommon for orders to break (for those curious, you can fix the white screen problem by going to the old drop-down menu and correcting your orders there). The sandbox is a broken mess that shouldn't have been deployed. Also, I don't think it's a feature that anyone wants. An analysis board where we can insert and delete units, move back and forth between moves, make variations, and even see bot's evaluations would be the tool people want. Comparable to a chess analysis board. Lastly, I don't understand why the "play beta" button had to be removed. If the dev was of the opinion that it was no longer in beta, then why not rename that button something else, like "interactive board". That would avoid all of the sad people who liked the old interface and it wouldn't default to making a new tab everytime you want to use the new board.
by kestasjk » Fri Mar 17, 2023 2:38 am
Rainfromabove wrote: ↑Thu Mar 16, 2023 2:35 pm Hi, not to be moaning but feels like in the last few months there keep being updates that are not well tested and range from making the site experience much worse to being minor annoyances Specific pointers/bugs please: - in games which you view in the old UI you can no longer click on the enlarged map function -> it just takes you to the new UI screen and doesn’t show the moves from last turn (eg trying to see failed supports) - order preview works about 50% of the time (at least on mobile), otherwise map seems to crash - the new display on mobile of the home page with the big new section means we have to now scroll past a ton of new games before you can get to the updates/notifs on games you are in - On the above why is it necessary to see a bunch of Sandboxed games that are about to start
by Rainfromabove » Thu Mar 16, 2023 11:10 pm
Ferdack wrote: ↑Thu Mar 16, 2023 5:01 pm Rainfromabove wrote: ↑Thu Mar 16, 2023 2:35 pm in games which you view in the old UI you can no longer click on the enlarged map function -> it just takes you to the new UI screen and doesn’t show the moves from last turn (eg trying to see failed supports) There is a quick fix this problem, when you try to click on the large map the URL is currently in this format: https://webdiplomacy.net/beta/?gameID=xxxxxx You can copy your game ID to the old map format, and manually adjust your turn number: https://webdiplomacy.net/map.php?gameID=xxxxxx&turn=x&mapType=large
Rainfromabove wrote: ↑Thu Mar 16, 2023 2:35 pm in games which you view in the old UI you can no longer click on the enlarged map function -> it just takes you to the new UI screen and doesn’t show the moves from last turn (eg trying to see failed supports)
by Troodonte » Thu Mar 16, 2023 8:56 pm
JECE wrote: ↑Thu Mar 16, 2023 5:42 pm It's just a Diplomacy adjudicator. Here is the thread where its implementation on webDip was first discussed: viewtopic.php?f=16&t=4565 Good to hear from you, Troodonte!
by sweetandcool » Thu Mar 16, 2023 6:17 pm
by Ferdack » Thu Mar 16, 2023 6:10 pm
sweetandcool wrote: ↑Thu Mar 16, 2023 6:00 pm An analysis board where we can insert and delete units, move back and forth between moves, make variations, and even see bot's evaluations would be the tool people want. Comparable to a chess analysis board.
by sweetandcool » Thu Mar 16, 2023 6:00 pm
by JECE » Thu Mar 16, 2023 5:42 pm
Troodonte wrote: ↑Thu Mar 16, 2023 2:53 pm Talking about that: what’s is a sandbox game?
by Ferdack » Thu Mar 16, 2023 5:01 pm
Top